Change to 'Nabble.toggleMsg' in 'js_basic_site_functions'??

Posted by MichaelAtOz on
URL: https://support.nabble.com/Change-to-Nabble-toggleMsg-in-js-basic-site-functions-tp7599051.html

I'm changing over from Firefox to PaleMoon.
On the later I was having a problem, every post showed:

Clicking the "Don't show this message again" made no difference, it keeps poping-up.

Initially I though it must be a PaleMoon issue, but looked into that and could not find a problem.

So I looked into the NAML.
subscription_reminder is where it happens.
    In it Nabble.toggleMsg is used to set a cookie via:
       onclick="Nabble.toggleMsg('ml-reminder', $(this).attr('checked'))"

That lives in:
    js_basic_site_functions
    Which is in:
        javascript_library.naml

Where the code is:
     Nabble.toggleMsg = function(id, hide) {
        if (hide)
            Nabble.setPersistentCookie(id, 'closed');
        else
            Nabble.deleteCookie(id);
    };

With that code and the above call, the cookie will never get set.
Yet in my Firefox cookie list, it exists, so it got set somehow in the past.

So I suspect that toggleMsg may have been changed somewhat recently.

Can anyone confirm that?
Is there some change log and/or source repository for such code?

EDIT:
Fixed by changing to:
onclick="Nabble.toggleMsg('ml-reminder', true)"

So why was it changed?