<nabble_embed/> tags don't work anymore

classic Classic list List threaded Threaded
14 messages Options
Reply | Threaded
Open this post in threaded view
|

<nabble_embed/> tags don't work anymore

DavidJCobb
Not too long ago, a user on Reaching Perfection reported that the <nabble_embed></nabble_embed> tags no longer work for embedding videos in posts.

An admin tested and found that the tags don't work in HTML-enabled posts. Another admin found that embedding is possible if one uses a standard embed code (no Nabble wrapper) in an HTML-enabled post, but while this workaround is sufficient, it is likely to inconvenience our members that aren't familiar with HTML.

The "Embed" button shown when editing posts still directs users to use the Nabble tags, so I'm assuming this is a bug. Is there a way for us to restore the nabble_embed functionality?
Reply | Threaded
Open this post in threaded view
|

Re: <nabble_embed/> tags don't work anymore

Pedro
Please, could you give me the url that your admin tried to embed?
My test forum.
Reply | Threaded
Open this post in threaded view
|

Re: <nabble_embed/> tags don't work anymore

DavidJCobb
I was unable to embed //www.youtube.com/embed/ZEBGCOCxLgA when using the nabble_embed tags. The URL came directly from YouTube's copy-and-paste embed code box.

As for the link my admin tried? I can post that, but judging by the video's title (though I haven't had time to actually watch it), it may be, um, crude. :\ It does have the same features as the URL I tried, though: missing protocol (which is weird, but the URL should still be valid), valid YouTube ID leading to a valid video.
Reply | Threaded
Open this post in threaded view
|

Re: <nabble_embed/> tags don't work anymore

Pedro
Ok, I'm working on it.
My test forum.
Reply | Threaded
Open this post in threaded view
|

Re: <nabble_embed/> tags don't work anymore

GregChapman
This topic may be relevant...

http://support.nabble.com/Embed-YouTube-not-working-tp7064607p7581077.html
Volunteer Helper - but recommending that users move off the platform!
Once the admin for GregHelp now deleted.
Reply | Threaded
Open this post in threaded view
|

Re: <nabble_embed/> tags don't work anymore

DavidJCobb
In reply to this post by Pedro
Found the problem! YouTube made a tiny update to one of their embed codes, which causes it to fail to match the built-in youtube_iframe_regex2. Specifically, the problem is that YouTube now shears the protocol off the URL, which causes the regex to fail. If the regex is edited to make the https: optional, then the issue should be resolved.

It looks like you guys've been maintaining the regexes for a while now, and they are default, so unless directed otherwise, I'll wait for you to fix it instead of implementing a NAML override.
Reply | Threaded
Open this post in threaded view
|

Re: <nabble_embed/> tags don't work anymore

Pedro
This post was updated on .
Did you correct our regex? Could you show me?
My test forum.
Reply | Threaded
Open this post in threaded view
|

Re: <nabble_embed/> tags don't work anymore

DavidJCobb
I have not corrected the regex on either of my apps, but I believe it can be fixed by changing the relevant macro to:

<macro name="youtube_iframe_regex2">
    <![CDATA[\s*<iframe width="\d+" height="\d+" src="(https?:|)//www.youtube.com/embed/[^"]+" frameborder="0"( allowFullScreen| allowfullscreen)?></iframe>\s*]]>
</macro>
Reply | Threaded
Open this post in threaded view
|

Re: <nabble_embed/> tags don't work anymore

Pedro
Please, override this macro like this:
 <override_macro name="youtube_iframe_regex2">
    <![CDATA[\s*<iframe width="\d+" height="\d+" src="(https:)?//www.youtube.com/embed/[^"]+" frameborder="0"( allowFullScreen| allowfullscreen)?></iframe>\s*]]>
</override_macro> 
My test forum.
Reply | Threaded
Open this post in threaded view
|

Re: <nabble_embed/> tags don't work anymore

GregChapman
This does seem to be a general issue as notified on the Free Support forum and needs a system wide fix.
Volunteer Helper - but recommending that users move off the platform!
Once the admin for GregHelp now deleted.
Reply | Threaded
Open this post in threaded view
|

Re: <nabble_embed/> tags don't work anymore

DavidJCobb
In reply to this post by Pedro
Pedro <Nabble> wrote
Please, override this macro like this:
I know that I can fix this with an override and will do so if you insist, but this isn't a forum-specific feature. It's a bug in a default macro that will affect all forums -- current YouTube embed codes lack a protocol, so they should fail that regex test in all forums. If the fix is applied on your end, then it should resolve the issue on all affected Nabble forums, without introducing the risk of conflicts should any of the default macros receive changes or rearrangements sometime in the future. :\
Reply | Threaded
Open this post in threaded view
|

Re: <nabble_embed/> tags don't work anymore

Pedro
Yes, we will update it on all servers. Please, use the override in the meantime.
My test forum.
Reply | Threaded
Open this post in threaded view
|

Re: <nabble_embed/> tags don't work anymore

Harvey
I am seeing this issue more and more too.

Can we tell forum members that this will be resolved eventually or soon?

None of these could be embedded:

http://forum.nyskiblog.com/My-Trip-to-Dorney-Park-tp4029703.html
HTTPS Please!
Reply | Threaded
Open this post in threaded view
|

Re: <nabble_embed/> tags don't work anymore

Pedro
Which code did you try to embed?
My test forum.