Bug Report: Email Posts Over-ride "Reply" Permission Settings

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Bug Report: Email Posts Over-ride "Reply" Permission Settings

GregChapman
At: http://seahawk-forum.968426.n3.nabble.com/Gallery-f1624462.html
I have a forum with the "Reply" permission removed for all users. When a forum user attempts a reply they get sent to the "Access Request" screen as expected.

However, when an email user replies their post does appear on the forum - not as a reply, but as a new topic.

In a test on another forum I see that locking a topic should generate an appropriate email. i.e.

-------------------
Delivery to the following recipient failed permanently:

    ml-node+xxxxxxx@n3.nabble.com

Your email to ml-node+xxxxxxx@n3.nabble.com has been rejected because you are not allowed to post to xxxxxx. Please contact the owner about permissions
-------------------

Surely, a similar email should be generated for "No Reply" forums as well?
Just a Volunteer Nabble Helper - because the nice folk at Nabble have helped me!
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Bug Report: Email Posts Over-ride "Reply" Permission Settings

Hugo <Nabble>
Administrator
It seems to me that the solution is to override the "save_post_by_email" macro like this:
<override_macro name="save_post_by_email" requires="post_by_email" unindent="true">
    <n.fix_threading/>
    <n.if.not.mail_author.can_post_under.replied_to_node>
        <then.throw_template_exception name="banned" />
    </n.if.not.mail_author.can_post_under.replied_to_node>
    
    <n.if.not.mail_author.can_post_under.posted_node>
        <then.throw_template_exception name="banned" />
    </n.if.not.mail_author.can_post_under.posted_node>    
    
    <n.save_to_post/>
</override_macro>
The override adds a new if statement to the macro. Can you please try this and let me know if the issue still happens? If this works, I will release it to all servers. Thanks for reporting the issue.
Official Nabble Administrator - we never ask for passwords.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Bug Report: Email Posts Over-ride "Reply" Permission Settings

GregChapman
Hi Hugo,

I now realise I've misreported this bug. Checks in my test forum - without installing your suggested code change - appear to confirm it.

Contrary to what I suggested earlier, when replying by email, if the forum has been set to "no Reply", you do get a "Delivery status Notification" with a message "Please contact the owner about permissions or visit the Nabble Support forum" (as you do with locked topics).

The bug turns out to be a little more esoteric.

In the case, on the SeaHawk forum, that prompted my report, the bug occurred because I had edited the original post's Subject line. As a result the reply came through with a different subject line to the original post and it is a documented feature that Nabble will process an email reply with a changed subject as a new topic.

Experiments in my test forum now suggest to me that this bug is more an undesirable side-effect of a "feature" which was intended to assist those folk who adopt poor email practice and expect to break threading with a change of subject line.

Probably only you can say if there is an easy way to code a test to determine if an email reply still has the original subject line in place, in which case it ought to be rejected, or whether it has an edited subject line created by the user replying and hence probably should be accepted by Nabble as a new topic.
Just a Volunteer Nabble Helper - because the nice folk at Nabble have helped me!
Loading...