Another NAML change. redirect_to

classic Classic list List threaded Threaded
13 messages Options
Reply | Threaded
Open this post in threaded view
|

Another NAML change. redirect_to

MichaelAtOz
Further to my previous post re toggleMsg, and thinking Palemoon  was the cause.

Another behaviour I thought was the browsers fault, but isn't.

When posting, the page presented after posting used to be the whole thread with the last post showing, recently that changed to just displaying the individual post.

That appears to be due to:
  edit_post
the redirect:
  <n.redirect_to.page_node.url/> 
 (I'm presuming it was changed)

When I change it to
  <n.redirect_to.node_page.page_node.url>
it behaves as it did before.

Are we going to find more of these changes?

Reply | Threaded
Open this post in threaded view
|

Re: Another NAML change. redirect_to

haozwang<Nabble>
Administrator
if you restore it to default can you see this issue again? when I am trying on my test forum I can see the whole thread with either custom configuration. can you show screen shots?
Reply | Threaded
Open this post in threaded view
|

Re: Another NAML change. redirect_to

MichaelAtOz
edit_post with <n.redirect_to.page_node.url/> 



edit_post with <n.redirect_to.node_page.page_node.url/>

After preview, before posting:
Reply | Threaded
Open this post in threaded view
|

Re: Another NAML change. redirect_to

MichaelAtOz
Oops, clicked the wrong 'post'...standby...
Reply | Threaded
Open this post in threaded view
|

Re: Another NAML change. redirect_to

MichaelAtOz
This post was updated on .
Hmmm...

I did it first on my test forum. It does not replicate the problem.
See below for the problem on the OpenSCAD forum where I first found it.    NOT-or-sort-of

Well after wasting my time trying all that it seems something has changed overnight (my Oz time ~midday now).

EDIT: Seems these not compiled conditions are happening frequently, red herring so ignore.
          but the last bit shows what is displayed after posting. See my next post for other observation.

The edit_post macro is no longer used.


(This is with the override)


(This is the without override i.e. deleted the override)


Looking at an reply page:


Click Edit this page:


Uses new_post. Yesterday it used edit_page.....

new_post does <n.redirect_to.new_node.url/> 

This is after clicking Reply, just before posting:


After posting (note the 'Message Preview'):


So it exhibits the behaviour I was originally complaining about.
Which interestingly doesn't happen on my test formum.

This is the test forum after posting a reply in the default no override state:


...I also find it interesting that my post of last night was deleted, which included this:

With a comment along the lines of 'There may be something else going on'
Reply | Threaded
Open this post in threaded view
|

Re: Another NAML change. redirect_to

MichaelAtOz
Now it appears that those posts with 'Message Preview' are not actually committing.



They do make it to the mailing list tho...



I'm wondering what's changed here, in new_post:


The above behaviour is consistent with new_node.is_associated_with_mailing_list_archive being true.
Thus the email gets sent by
  send_mail_to_list  (with just "--/n Sent from:...")
v's
  send_node_as_email (which sends more elaborate emails)

Where is is_associated_with_mailing_list_archive (a NAML Binary) set?

BTW my test forum does not have a linked mailing list.
Reply | Threaded
Open this post in threaded view
|

Re: Another NAML change. redirect_to

MichaelAtOz
I also considered whether the
  <n.check_antispam_submit bypass="preview"/> 
was triggering the
  <n.catch_exception. id="save-block"> 

But as the email IS sent that can't be.
Reply | Threaded
Open this post in threaded view
|

Re: Another NAML change. redirect_to

MichaelAtOz
A new topic also behaves the same:


So the OpenSCAD Forum is effectively DOWN.
Reply | Threaded
Open this post in threaded view
|

Re: Another NAML change. redirect_to

MichaelAtOz
This post was updated on .
Although the email was of the more elaborate type: EDIT: No it isn't, that was just my sig....(I'm walking AFK now...)


Implying that it was sent by send_node_as_email... EDIT: No that was send_mail_to_list too...

I went back and the New Post has now appeared, as did a recent reply.

Something is fishy....



Reply | Threaded
Open this post in threaded view
|

Re: Another NAML change. redirect_to

MichaelAtOz
In reply to this post by haozwang<Nabble>
The 'send_mail_to_list'  format shown above.

The 'send_node_as_email' format is:


I went back to the archive to find when the type of email changed.
The last '-- View this message in context:' was 29th Aug, the first '-- Sent from' was 31st Aug.

So what changed then?
Reply | Threaded
Open this post in threaded view
|

Re: Another NAML change. redirect_to

haozwang<Nabble>
Administrator
In reply to this post by MichaelAtOz
the thing here is that if you are messing around with stuff, you should make your test forum an archive and create a dummy mailing list to test stuff on it...
Reply | Threaded
Open this post in threaded view
|

Re: Another NAML change. redirect_to

MichaelAtOz
haozwang<Nabble> wrote
the thing here is that if you are messing around with stuff, you should make your test forum an archive and create a dummy mailing list to test stuff on it...
Yes, I have a test mailing list, hadn't got around to reconfiguring it.

I had not been 'messing around' of any significance AFAIK, I had not done any changes to OpenSCAD NAML for quite some time until this last week of so, and everything I did recently was to debug or temporary workaround to something that changed, presumably due to wider Nabble changes. (both the 'is_hidden_mailing_list' & 'Nabble.toggleMsg' bugs)
I believe my last fairly minor changes were end of July. Cosmetic changes.
As indicated above something changed ~ 29th Aug - 31st Aug.
This was noticed, in hindsight, by the different format emails.

There is still some problem causing posts to display like this (instead of returning to the list of posts):

(note it says, 'this message was sent', this is after pressing the Post button)

Just to clarify, OpenSCAD has always been associated with a mailing list & prior to 31 Aug, the send_node_as_email type ('View this message in context:) was the email sent when posting.
So given the NAML code as exists now, in New_Post (or perhaps Reply previously used another macro?) must have been different prior to 31 Aug.
Something changed, and it broke posting...

These are the only OpenSCAD Overrides:
Reply | Threaded
Open this post in threaded view
|

Re: Another NAML change. redirect_to

haozwang<Nabble>
Administrator
technically the message is a preview because the post will not show in the archive until the mailing-list has accepted the post.